Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow that actually caches the dependencies. #752

Merged
merged 9 commits into from
Dec 6, 2024
Merged

Conversation

realkaranvir
Copy link
Contributor

Also shortened it to not have duplicate steps for pull requests versus pushes/merges to main. It uses a conditional check to determine whether to push to dockerhub.

Copy link
Member

@bholt13 bholt13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check line 5, 73-75

Copy link
Contributor

@JLpro-cd JLpro-cd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Job, Karan

@bholt13 bholt13 self-requested a review December 6, 2024 18:20
Copy link
Member

@bholt13 bholt13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Copy link
Contributor

@JLpro-cd JLpro-cd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great now, finalized

Copy link
Contributor

@thekevinWHYuan thekevinWHYuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@realkaranvir realkaranvir merged commit 75e0a99 into master Dec 6, 2024
3 checks passed
@realkaranvir realkaranvir deleted the karan branch December 6, 2024 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants